Skip to content

Fix type error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakebook wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix type error #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7957b0b
Add fail test
sakebook Jul 15, 2019
8d76875
Fix type cast error
sakebook Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion key_value_store_web/lib/key_value_store_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class WebKeyValueStore implements KeyValueStore {
final Storage _storage;

@override
Set<String> getKeys() => _storage.keys;
Set<String> getKeys() => _storage.keys.toSet();

@override
bool getBool(String key) => _storage[key] == 'true';
Expand Down
6 changes: 6 additions & 0 deletions key_value_store_web/test/key_value_store_web_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ void main() {
expect(localStorage.getKeys(), ['key #1', 'key #2']);
});

test('getKeys type', () {
when(mockStorage.keys).thenReturn(List());

expect(localStorage.getKeys().runtimeType, Set<String>().runtimeType);
});

test('getBool', () {
when(mockStorage['myTrueBool']).thenReturn(json.encode(true));
when(mockStorage['myFalseBool']).thenReturn(json.encode(false));
Expand Down