Add accounting rules for new exchange transfer type #258
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyoder
force-pushed
the
exchange-transfer-rules
branch
from
b7d5e0a to
989afa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules are similar to what we had for the deposit/withdraw types. One thing different though is that I set
count_entire_amount_spendas true for the fee subtype. Most fees we have this set, but for some reason we didn't on the deposit/withdrawal fees. I think this was a mistake.Also adjused the eth_utils version since it was making the CI fail (we already adjusted this in the
nextbranch)