Stop remapping RedisModule_OnLoad; add test module that exports it via version script#6
Open
roshkhatri wants to merge 1 commit into
Open
Conversation
Signed-off-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RedisModule_OnLoadentry-point via macro substitution because it can break modules that use a linker version script to exportRedisModule_OnLoadexplicitly.valkey-servercontinues to load modules that export the originalRedisModule_OnLoadsymbol.Description
RedisModule_OnLoadtoValkeyModule_OnLoadinsrc/redismodule.hand add a comment explaining why the symbol must be left unmapped.tests/modules/hellovalkey.cthat definesRedisModule_OnLoadand a version scripthellovalkey.versionthat exportsRedisModule_OnLoad.tests/modules/Makefileto buildhellovalkey.sousing the version script on Linux and include it in the test modules list.tests/unit/moduleapi/redismodule_onload.tclthat verifies theRedisModule_OnLoadsymbol is exported (nm -Don Linux) and that the module can be loaded and unloaded by the server.Testing
hellovalkey.so(Linux path using the version script) and the build succeeded.tests/unit/moduleapi/redismodule_onload.tclwhich checks the exported symbol and performsMODULE LOAD/MODULE UNLOAD, and the test passed.Codex Task