Skip to content

docs(turtlesim): fix incomplete remapping in section 6 for turtle2 teleop (backport #6585)#6683

Merged
fujitatomoya merged 1 commit into
rollingfrom
mergify/bp/rolling/pr-6585
May 12, 2026
Merged

docs(turtlesim): fix incomplete remapping in section 6 for turtle2 teleop (backport #6585)#6683
fujitatomoya merged 1 commit into
rollingfrom
mergify/bp/rolling/pr-6585

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 12, 2026

Description

The remapping command in the "6 Remapping" section of the turtlesim tutorial
only remaps the cmd_vel topic, which means arrow key movement works for
turtle2 but the absolute orientation keys (F, G, B, V, C) silently continue
to control turtle1 because the rotate_absolute action is not remapped.

Two changes are made:

  • Updated the prose description to mention both cmd_vel and rotate_absolute
  • Added --remap turtle1/rotate_absolute:=turtle2/rotate_absolute to the shell command

Did you use Generative AI?

Claude (Sonnet 4.6) was used to assist with drafting the commit message and PR description.

Additional Information

The fix applies to the jazzy branch. The same issue may be present in other
supported distributions (humble, rolling) and may warrant separate PRs.


This is an automatic backport of pull request #6585 done by Mergify.

…leop (#6585)

The remapping example in the "6 Remapping" section only redirected the cmd_vel topic, leaving the rotate_absolute action still targeting turtle1. As a result, arrow key movement worked correctly for turtle2, but the absolute orientation keys (F, G, B, V, C) silently continued to rotate turtle1 instead.

Two changes are made:

1. The prose description is corrected from: "The way to change this behavior is by remapping the cmd_vel topic."

to: "The way to change this behavior is by remapping the cmd_vel topic and the rotate_absolute action."

2. The shell command is updated to include the missing --remap flag:
Before:
ros2 run turtlesim turtle_teleop_key \
--ros-args --remap turtle1/cmd_vel:=turtle2/cmd_vel

After:
ros2 run turtlesim turtle_teleop_key \
--ros-args --remap turtle1/cmd_vel:=turtle2/cmd_vel \
--remap turtle1/rotate_absolute:=turtle2/rotate_absolute

Testing:
Verified by running both teleop nodes simultaneously — all keys (arrows and orientation) now correctly control their respective turtles.

Signed-off-by: Sai Akella <64731868+A-C-Sai@users.noreply.github.com>
(cherry picked from commit 1c23d4f)
@fujitatomoya fujitatomoya enabled auto-merge (squash) May 12, 2026 04:26
@github-actions
Copy link
Copy Markdown

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/25713278466/artifacts/6935809361.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-6683/index.html in your favorite browser

@fujitatomoya fujitatomoya merged commit 9412d95 into rolling May 12, 2026
10 of 12 checks passed
@fujitatomoya fujitatomoya deleted the mergify/bp/rolling/pr-6585 branch May 12, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants