Define mmk_noreturn if __STDC_VERSION__ >= 201112L#29
Merged
clalancette merged 1 commit intoros2:ros2from Feb 10, 2024
Merged
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Member
Author
|
Should this be contributed upstream instead/in addition to this PR? |
I think we can open it in addition to this PR. Upstream is not very active, I've had PRs waiting quite a while there. |
clalancette
approved these changes
Feb 9, 2024
clalancette
left a comment
There was a problem hiding this comment.
Looks reasonable to me, thanks. I'm also going to open a corresponding PR to https://github.com/ros2/mimick_vendor, and run CI for this over there.
|
CI was happy in ros2/mimick_vendor#34, so going ahead and merging this. I'll then update that PR to point to the correct commit. Thanks for the fix. |
christophebedard
pushed a commit
to christophebedard/Mimick
that referenced
this pull request
Feb 10, 2024
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Member
Author
|
Contributed upstream: Snaipe#40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
CMAKE_C_STANDARDis set to 11 (e.g., globally), thenmmk_noreturnis never defined, which results in errors like this:_Noreturnis deprecated in C23, but I'm not sure if we should worry about that just yet. See https://en.cppreference.com/w/c/language/_Noreturn.Relates to Snaipe#28, but using C99 is not really a great solution.