Tutorial for Ground Consistency Layer#911
Conversation
|
I guess the pre-commit failed job is not a problem, or? |
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
|
Force pushes are because I always forget to somehow sign-off the commits... |
|
Check on the precommit CI issues to resolve - it shows issues you need to fix in your file |
There was a problem hiding this comment.
I think you may also benefit from the next draft from reading a few of the existing Nav2 tutorials. This doesn't really step through how to set it up (i.e. add the layer to your navigation yaml config file) or understand the parameters (here's some key parameters to tune/setup) or any of the key user-facing tutorial features needed, I don't think. Those are the details people will read this to learn -- how to setup & tune & use.
I think you can blow past the gazebo world/model details, since those are just to show case the feature. Tell them to launch Nav2 + gazebo using this launch file (which does Nav2 + gazebo + KISS ICP + husky) and just tell them it launches all of these things (and brief reasons about what they do) to as a test / demo environment. I don't think it needs to be expanded much past that since the point here is more related to your algorithm + the costmap layer.
| - **On slopes**: Ground segmentation classifies the slope as traversable (not blocked) | ||
| - **Over small obstacles**: Debris below robot height doesn't appear as lethal obstacles | ||
| - **Under overpasses**: If your world has them, the robot can navigate underneath | ||
|
|
There was a problem hiding this comment.
Here's a good place to add a youtuve video or two embedded
There was a problem hiding this comment.
I am preparing a video, will update you on it
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
|
@SteveMacenski Thanks for the detailed review. I have overhauled the tutorial. It should look much better now. Pleas let me know if further changes are needed. |
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
There was a problem hiding this comment.
Much better, but some linearization issues for a smooth workflow. Otherwise, I think we should be ready soon.
I'd suggest readding your videos in the "Demo" section for other Demo videos you have (I've seen one in a mine or something and another with real data on a forklift or something?). Even though they're not for this demo simulation, it is useful to show more examples of it in use and that it really does work. Usually the only reason more tutorials don't have more videos is because we don't have many videos, or videos that show unique things. You have several, use them to promote! :-)
|
I don't see the updates pushed here yet to look at :-) |
|
@SteveMacenski I have pushed the updates. Made corrections and added three examples from real world datasets in outdoor setting. I hope the gif files are not too large? One gif is 9 MB, one 21 MB and one is 72 MB. I guess the 72 MB one is too large, I can cut it down if that is an issue. |
|
I'm not able to go over it today, but yes 72MB is too large, can you reduce to under 20? |
|
I tried removing that large file to replace with a 10 mb file but somehow seems to not work. I will try it again |
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
|
Now the large file is replaced by a 10 mb file... |
|
See the remaining 2 open comments (you may have missed them if you didn't hit "expand").
and
Otherwise, perfect and approved! |
Signed-off-by: haider8645 <haider_lodhi@hotmail.com>
Oh yes.. I missed them. Both points are done. Thank you so much for taking the time to review and give comments! |
Thanks to you! I learned many things from this PR experience. |
|
Can merge with the tutorial source code! Thanks for your diligence and attention :-) |
Basic Info
Related PR: ros-navigation/navigation2_tutorials#140
Description of contribution in a few bullet points
Performance Anaylsis on the demo scenario: