Tutorial: Adding end-to-end custom navigation capabilities to Nav2#903
Tutorial: Adding end-to-end custom navigation capabilities to Nav2#903NOTMOVETON wants to merge 34 commits intoros-navigation:masterfrom
Conversation
|
@SteveMacenski Also I have added gif in overview section and demo+explanation video at step 7 |
|
|
||
| For a better understanding, here is the image of the pipeline flow: | ||
|
|
||
| .. image:: images/Writing_new_nav2_full_pipeline/image4.png |
There was a problem hiding this comment.
Note to self: Do this in my styling
There was a problem hiding this comment.
i think something I need to put together with my graphics packages once we're ready to merge
There was a problem hiding this comment.
ok, I will change small fixes now and basically its done :)
34a979f to
3fb20d9
Compare
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
|
Let me know when I should check again. Please leave the graphics comment open as a reminder to myself |
Signed-off-by: d.kotov <moveton40@gmail.com>
Please check again :) |
|
Asked for some outside feedback: https://www.linkedin.com/posts/steve-macenski-41a985101_nav2-share-7453121552893542401-L8Bf?utm_source=share&utm_medium=member_desktop&rcm=ACoAABnzaBYBjQwl9dCmBDFWicTZDTYTVfoqy2I Otherwise other than the open item I just commented on about the |
Signed-off-by: d.kotov <moveton40@gmail.com>
There was a problem hiding this comment.
It is a bit unclear to me what the "Goal msg" refers to from SetBlandeState and SetCameraYaw
There was a problem hiding this comment.
@SteveMacenski said that he will do it himself, so I guess the image will change as well as descriptions in the picture
|
@mini-1235 Is there anything else you think its better to change/add/remove? Maybe the structure or some section are unclear? |
|
Comments are getting lost in the sea of review remarks, I think this is the last thing I asked for that needs to be done: Yes :-) (both in the tutorial and in the source code) |
Signed-off-by: d.kotov <moveton40@gmail.com>
|
@SteveMacenski |
|
I was hoping to get 1x more review from a new person before merging... someone that isn't a maintainer or understands Nav2 super well so that we can an outside perspective on what's missing or unclear |
|
I asked in large robotics group if anyone can do a review, hopefully someone will pick it up soon |
EricoMeger
left a comment
There was a problem hiding this comment.
Overall I think this tutorial is good. I hadn't had the chance to implement my own BT node yet, and this gave me a good understanding of how to approach it.
One minor thing: it might be worth showing a CMakelists example for nav2_operations_bt_nodes, since that package involves plugin registration which can be a bit cumbersome. I don't really have a strong opinion on this, just a thought.
It has been excluded on purpose, as said in guide more info could be found in related package. |
Signed-off-by: d.kotov <moveton40@gmail.com>
Signed-off-by: d.kotov <moveton40@gmail.com>
|
@SteveMacenski Hi! Is there something else I can do? |
|
Sorry, I've been behind and a bit sick. This LGTM. Please open a nav2 tutorials PR with the code that matches the tutorial for users to follow through as a full example. Then I can update the graphic and merge |
Basic Info
Description of contribution in a few bullet points
Tutorial is about: