Fixed cors ascii rick roll instead of opening gif in new window#85
Fixed cors ascii rick roll instead of opening gif in new window#85jandobrx wants to merge 8 commits intorootvc:mainfrom
Conversation
|
omg amazing This has been on my feature list for over a year and never really gotten around to it. Thank you!! Your test deployment shows it working on desktop for me (Chrome and Safari for Mac) but not getting it to work on mobile (mobile Safari) - it shows Nice try but then a bunch of blank lines. Given we're a VC website, iOS is actually our #1 platform haha - this is so close, I'll try to dig into debugging it on mobile Safari and then I 100% want to merge. Thank you!! |
This commit switches from injecting a video, to using a 54 frame ASCII Rick Roll. Note that Mobile and Desktop versions contain two different AA Arrays due to resolution constrains.
|
We were super excited to hear that! @gurgenbrx pushed another version last night with a fix to the mobile/Safari! Also seems to be a strange bug I was able to load it on my iphone/safari, I believe it was an issue with netlify serving video as a CDN! The new patch should fix all the views for mobile! We also used the 40 line convention to switch a view for the main ASCII animation from desktop to mobile! Fortunately when dealing in the tokenization world we've become experts with characters and ascii manipulation :) There's also a quick AA tutorial if you want to turn any other video/image into this format! e25150d |
3 participants
We saw that a recent PR featured a rick roll curl, thought it was a great addition but had a CORS issue. Wanted to fix it!
Updated Xterm to the new version, fixed cursor position bug after setCurrentLine(), added a video that appends in the DOM.
Test Netlify Deployment w/changes:
https://main--test-cli-rick.netlify.app/