-
Notifications
You must be signed in to change notification settings - Fork 29
feat(auth): add Microsoft ADFS auth support #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rootflo-hardik
wants to merge
8
commits into
develop
Choose a base branch
from
CU-86d36z51h-Microsoft-ADFS
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6e3e523
feat(auth): add Microsoft ADFS auth support
rootflo-hardik 937bf6d
resolved review comments
rootflo-hardik 3e2a737
implement Redis-backed OAuth state CSRF hardening
rootflo-hardik eed42eb
debug logs for adfs
rootflo-hardik 047dfca
adfs frontend changes
rootflo-hardik 0fb8040
enable authenticator tab
rootflo-hardik 19d43f8
feat: handle adfs auth for users without email
vishnurk6247 f9cf835
add username in get users query
vishnurk6247 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...repo_module/db_repo_module/alembic/versions/2026_06_11_2008-add_username_to_user_table.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| """add username to user table | ||
|
|
||
| Revision ID: a1b2c3d4e5f8 | ||
| Revises: 3b5b1bf90e6c | ||
| Create Date: 2026-06-11 20:08:00.000000 | ||
|
|
||
| """ | ||
|
|
||
| from typing import Sequence, Union | ||
|
|
||
| from alembic import op | ||
| import sqlalchemy as sa | ||
|
|
||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision: str = 'a1b2c3d4e5f8' | ||
|
|
||
| down_revision: Union[str, None] = '3b5b1bf90e6c' | ||
|
|
||
| branch_labels: Union[str, Sequence[str], None] = None | ||
|
|
||
| depends_on: Union[str, Sequence[str], None] = None | ||
|
|
||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| op.add_column( | ||
| 'user', | ||
| sa.Column('username', sa.String(length=150), nullable=True), | ||
| ) | ||
| op.create_unique_constraint('uq_user_username', 'user', ['username']) | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| op.drop_constraint('uq_user_username', 'user', type_='unique') | ||
| op.drop_column('user', 'username') | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the redirect_uri placeholder path.
The placeholder shows
/v1/oauth/microsoft-adfs/callback, but the server-side callback route is registered at/v1/oauth/adfs/callback(without "microsoft-" prefix). Users copying this placeholder will configure an incorrect redirect_uri, causing authentication callbacks to fail.📝 Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents