Merged
Conversation
haileyok
approved these changes
Apr 1, 2026
Collaborator
haileyok
left a comment
There was a problem hiding this comment.
lgtm, and i like the CAST name personally since STRING feels a bit weird for this sort of thing imo
haileyok
requested changes
Apr 1, 2026
Collaborator
haileyok
left a comment
There was a problem hiding this comment.
oh i think it needs to get registered here? https://github.com/roostorg/osprey/blob/main/osprey_worker/src/osprey/worker/_stdlibplugin/udf_register.py#L68 (just req'ing changes so someone else doesnt merge on accident but otherwise looks good)
Contributor
Author
Good catch! I updated the PR to add the missing piece. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to add a new ParseInt UDF to the sml rules language. The UDF converts a numeric string to an integer.
Example sml:
note: I wasn't too sure on what category to put this udf into. I am open to feedback to change the name.
Checklist
uv run ruff check .passes (no unused imports or other lint errors)uv tool run fawltydeps --check-unused --pyenv .venvpasses (no unused dependencies)