Open
Conversation
serendipty01
force-pushed
the
add-oidc-sso
branch
7 times, most recently
from
97bba63 to
515762c
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
2 times, most recently
from
298aa43 to
3cd5807
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
from
3cd5807 to
6bcf124
Compare
serendipty01
force-pushed
the
add-oidc-sso
branch
from
6bcf124 to
87e92bd
Compare
serendipty01
requested review from
a team,
cassidyjames,
dom-notion,
juanmrad,
julietshen,
pawiecz and
vinaysrao1
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
Currently, Coop only supports SAML for Single Sign-On (SSO). This PR adds OpenID Connect (OIDC) support to enable modern authentication flows and provide better compatibility with identity providers that support OIDC.
This PR is using openid-client library
TODO
client_secret_basicorclient_secret_postTests
Tested locally using Authelia
will add screenshots/video later
(Optional) Rollout Plan