Add support for rubyzip 3.x

[jukra]

Summary

Added support for rubyzip 3.0.0 and made it the minimum required version.

Other Information

Related issue: #621
Rubyzip upgrade instructions: https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x#open

[simonoff]

@jukra thank you for yyour help. Can you please add a changelog?

[jukra]

@jukra thank you for yyour help. Can you please add a changelog?

@simonoff Done!

[jukra]

Also added the '< 4.0.0' for gemspec

[simonoff]

Also added the '< 4.0.0' for gemspec

Thank you.

But i think we need to notice that old rubyzip will not work anymore. If you want to add just a support for 3.0 then i think better to have a detection of version and different behaviour depend on it. Or fully deprecation of < 3.0 versions.

[jukra]

Thank you.

But i think we need to notice that old rubyzip will not work anymore. If you want to add just a support for 3.0 then i think better to have a detection of version and different behaviour depend on it. Or fully deprecation of < 3.0 versions.

Yeah sorry I was unclear, the current requirement is:

spec.add_dependency 'rubyzip', '>= 3.0.0', '< 4.0.0'

so it's fully deprecating < 3.0 versions. I just added the '< 4.0.0' for future.

[simonoff]

Thank you.
But i think we need to notice that old rubyzip will not work anymore. If you want to add just a support for 3.0 then i think better to have a detection of version and different behaviour depend on it. Or fully deprecation of < 3.0 versions.

Yeah sorry I was unclear, the current requirement is:

spec.add_dependency 'rubyzip', '>= 3.0.0', '< 4.0.0'

so it's fully deprecating < 3.0 versions. I just added the '< 4.0.0' for future.

Thank you!

Ok, then also need to mentioned that we dropped support for rubyzip < 3.0

[jukra]

@simonoff added now a note about that as well to changelog d9e83d6

[simonoff]

@jukra thank you!

[ecentell-CPF]

Do you know when this will be published against rubygems.org?

[ecentell-CPF]

Just checking in on publishing this version? If this is an inappropriate place to ask about rubygems.org publish please let me know.

[jukra]

I think @simonoff is releasing soon #630

[simonoff]

Released!

[PikachuEXE]

Please also check roo-rb/roo-xls#64 for roo-xls