Cannot select same option for multiple dropdowns#142
Open
ledenis wants to merge 2 commits intoromgain:masterfrom
Open
Cannot select same option for multiple dropdowns#142ledenis wants to merge 2 commits intoromgain:masterfrom
ledenis wants to merge 2 commits intoromgain:masterfrom
Conversation
Contributor
Author
|
Note: I did not add a fix. I only added a failing test (inspired from #47 ) |
Owner
|
Thanks a lot for reporting this @ledenis ! Would you be able to contribute a fix? |
Contributor
Author
|
I was thinking about it, not sure if I can find a reliable fix. I saw that an attempt has been made to improve Meanwhile, I found a workaround: pass a custom container A similar approach was found by someone else: https://stackoverflow.com/questions/70018351/react-select-event-doesnt-trigger-the-onchange-function-to-set-the-value-during |
Contributor
Author
|
I pushed a fix 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fails to select the same option when there is multiple dropdowns.
It seems that
getReactSelectContainerFromInputgoes to far in the ancestor tree. When trying to click on the option, it sees the text from the other dropdown.