Open
Conversation
--- Configure firebase(auth+db) --- Adding user to db --- Show errors and loaders in forms
# Conflicts: # admin-panel/src/App.js # admin-panel/src/ducks/auth.js # admin-panel/src/redux/reducer.js
Merge branch 'master' of https://github.com/romabelka/advreact_04_12 # Conflicts: # admin-panel/src/App.js # admin-panel/src/ducks/auth.js # admin-panel/src/redux/reducer.js
romabelka
reviewed
Dec 14, 2017
|
|
||
| const auth = firebase.auth() | ||
|
|
||
| expect(JSON.stringify(generator.next().value)).toEqual(JSON.stringify( |
Owner
There was a problem hiding this comment.
stringify - не очень идея, там ведь функции сравнивать нужно
Author
There was a problem hiding this comment.
у меня тест валился, но различий между пришедшими данными и ожидаными не было, так и написано было Contents are identical, но тест не проходил. со stringify проходил.
|
|
||
| case GET_EVENTS_SUCCESS: | ||
| return state | ||
| .update('entities', entities => entities.push(Object.values(payload.events))) |
Owner
There was a problem hiding this comment.
Ок, но я бы хранил id в объектах
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home Task 2. Panchenko Svetlana.
##HT2.1 Написать тесты на auth
##HT2.2 Чистить форму people после успешного добавления в стор
##HT2.3 Отображать список людей
##HT2.4 Загружать и отображать список ивентов