fix: restore access to confirm mentor registration#2870
Draft
aliakseitokarev wants to merge 4 commits intomasterfrom
Draft
fix: restore access to confirm mentor registration#2870aliakseitokarev wants to merge 4 commits intomasterfrom
aliakseitokarev wants to merge 4 commits intomasterfrom
Conversation
aliakseitokarev
force-pushed
the
fix/mentor-confirm-access
branch
from
4c2178b to
c0d75f5
Compare
emp74ark
reviewed
Nov 12, 2025
| } | ||
| const courseToConfirm = await new CoursesApi().getCourseByAlias(alias as string); | ||
| const isInvited = mentor?.preselectedCourses?.includes(courseToConfirm?.data.id) ?? false; | ||
| return isInvited; |
Contributor
There was a problem hiding this comment.
How about:
return !!mentor?.preselectedCourses?.includes(courseToConfirm?.data.id);| <ActiveCourseProvider | ||
| publicRoutes={['/login', '/registry/mentor', '/registry/student', '/course/mentor/confirm']} | ||
| publicRoutes={['/login', '/registry/mentor', '/registry/student']} | ||
| mentorConfirmRoute="/course/mentor/confirm" |
Contributor
There was a problem hiding this comment.
This route was excluded from the publicRoutes, but some children render depends on publicRoutes:
if (isPublicRoute && router.isReady) {
return <>{children}</>;
}Is it expected?
| @ApiForbiddenResponse() | ||
| @ApiOkResponse({ type: CourseDto }) | ||
| @UseGuards(DefaultGuard) | ||
| public async getByAlias(@Req() _: CurrentRequest, @Param('courseAlias') courseAlias: string) { |
Contributor
There was a problem hiding this comment.
Does the request object used here?
AlreadyBored
approved these changes
Nov 17, 2025
Contributor
|
@aliakseitokarev please resolve code review concers and merge conflicts and we're good to go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
Issue:
Mentor can't accept the invitation.
Description:
Add the mentorConfirmRoute to ActiveCourseProvider, incorporating the necessary checks.
Self-Check: