feat: add button 'Done Task' for auto-task#2813
Draft
aliakseitokarev wants to merge 5 commits intomasterfrom
Draft
feat: add button 'Done Task' for auto-task#2813aliakseitokarev wants to merge 5 commits intomasterfrom
aliakseitokarev wants to merge 5 commits intomasterfrom
Conversation
aliakseitokarev
changed the title
|
|
||
| const score = verifications?.[0]?.score ?? null; | ||
| const isMinimumScoreDone = score >= publicAttributes.tresholdPercentage; | ||
| console.log(isMinimumScoreDone); |
| </Paragraph> | ||
| </Col> | ||
| <Col span={24}> | ||
| <Col span={24} style={{ display: 'flex', justifyContent: 'space-between' }}> |
Contributor
There was a problem hiding this comment.
Will Col + Row work instead?
| const [activeTab, setActiveTab] = useState(CourseTaskStatus.Available); | ||
| const statuses = useMemo(() => tasks?.map(t => t.status) || [], [tasks]); | ||
| const filteredTasks = useMemo(() => tasks?.filter(t => t.status === activeTab) || [], [tasks, activeTab]); | ||
| const isAvailableTab = activeTab === CourseTaskStatus.Available ? false : true; |
Contributor
There was a problem hiding this comment.
this naming is confusing, isAvailableTab = true when active tab != "Available"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
Issue:
Description:
Self-Check: