Guide sender-domain writes to global lane#35
Merged
Conversation
Sender-domain enablement is an Email Sending write path that needs the global lane for private maildesk zones. The catalog already drives command generation and capabilities docs, so pin the operation to the global lane, teach guide/classify to fall back to a single policy lane when live lane comparison has no answer, and add static contract coverage for the generated global-lane commands.
Owner
Author
|
@codex Please review the sender-domain lane guidance fallback. The part I am least certain about is whether falling back to a single explicit policy lane should live at the helper level or only in guide/classify. |
Owner
Author
|
Local proof is green: red-first static assertion, no-auth guide/classify checks, bash syntax, diff check, capabilities regeneration, and full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sender_domain enableas a global-lane write in the surface catalog and capabilities matrix.guide/classifyto fall back to a single explicit policy lane when live lane comparison has no recommendation.cfctl guide sender_domain enableemits global-lane preview/apply/verify commands.Test plan
./scripts/verify_static_contract.shfailed on missing sender-domain global lane assertionenv -u CF_DEV_TOKEN -u CF_GLOBAL_TOKEN -u CLOUDFLARE_API_TOKEN -u CLOUDFLARE_ACCOUNT_ID CF_SHARED_ENV_FILE=/nonexistent/cfctl-empty-env CF_REPO_ENV_FILE=/nonexistent/cfctl-empty-env ./cfctl guide sender_domain enable --zone example.com --name example.comenv -u CF_DEV_TOKEN -u CF_GLOBAL_TOKEN -u CLOUDFLARE_API_TOKEN -u CLOUDFLARE_ACCOUNT_ID CF_SHARED_ENV_FILE=/nonexistent/cfctl-empty-env CF_REPO_ENV_FILE=/nonexistent/cfctl-empty-env ./cfctl classify sender_domain enable --zone example.com --name example.combash -n commands/cfctl.sh scripts/lib/cfctl.sh cfctlgit diff --check./scripts/verify_static_contract.shRisk / review focus
dev,globalwrites.main; local static contract is the meaningful proof for this change.