Resolve lifecycle specs from caller cwd#33
Merged
Conversation
Resolve relative hostname and maildesk lifecycle spec paths against the caller's working directory when that file exists, falling back to the control-plane state directory for built-in examples. This keeps app-repo cfctl invocations from looking for private desired-state files under the cfctl repo while preserving the existing checked-in examples. Add a maildesk contract regression for caller-relative specs.
Owner
Author
|
@codex Please review the lifecycle spec resolver change, especially fallback ordering when a relative path exists both in the caller repo and under cfctl state examples. |
Owner
Author
|
Local proof is green ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostnameandmaildesk-cflifecycle--filepaths against the caller's working directory when that file exists.state/directory so existing built-in examples keep working.Test plan
python3 -m py_compile scripts/cf_maildesk_cf_lifecycle.py scripts/cf_hostname_lifecycle.pybash scripts/verify_maildesk_cf_contract.sh./scripts/verify_static_contract.sh/Users/star/dev/star-maildesk-cf:cfctl maildesk-cf verify --file config/desired-state.local.json./scripts/verify_public_contract.shblocked locally:CFCTL_PUBLIC_CONTRACT_ZONEis not set for live DNS/token smoke testsRisk / review focus
state/contain a same-named relative spec.