Skip to content

[codex] Fix agent mode tray mute sync#606

Merged
rogerchappel merged 1 commit into
mainfrom
codex/fix-agent-mode-tray-loop
Jun 1, 2026
Merged

[codex] Fix agent mode tray mute sync#606
rogerchappel merged 1 commit into
mainfrom
codex/fix-agent-mode-tray-loop

Conversation

@rogerchappel
Copy link
Copy Markdown
Owner

Summary

  • keep agent-mode mic/audio mute changes synchronized with the tray in the same update batch
  • reset tray playback and mute state when entering or exiting agent mode
  • route both normal and immersive VoiceAgent mic controls through the shared sync handler

Root Cause

VoiceAgent deactivation updated local agent mute state first, while the tray-to-agent sync effect still saw stale tray values in the same render cycle and wrote the old values back. That feedback caused flickering and could trigger React maximum update depth errors.

Verification

  • git diff --check
  • pnpm typecheck
  • pnpm lint:check (passes with existing warnings)
  • pnpm build (pre-push hook; passes with existing Turbopack NFT warnings)
  • local browser smoke against http://127.0.0.1:3000/chat reached the unauthenticated setup screen with no console errors; agent-mode interaction was not manually reproduced because this clean worktree has no signed-in user/runtime state

Risk

Medium: touches chat agent-mode and tray voice state synchronization only.

@rogerchappel rogerchappel marked this pull request as ready for review May 31, 2026 22:46
@rogerchappel rogerchappel merged commit 75f30a4 into main Jun 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant