feat(synology): add support for custom fields in C2 Password CSV#244
Open
AhmedOsman101 wants to merge 1 commit into
Open
feat(synology): add support for custom fields in C2 Password CSV#244AhmedOsman101 wants to merge 1 commit into
AhmedOsman101 wants to merge 1 commit into
Conversation
- parse JSON data from the "Others" column - extract custom text and autofill fields - add unit tests for valid and malformed CSV files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synology C2 Password stores custom fields (registration fields, autofill hints, free-text notes) as JSON in the
Otherscolumn.The base CSV parser discards these, causing custom fields to be silently skipped during import with
--all.parse()override forSynologyC2CSVclassTextandAutofillWebcustom entries fromOthersJSONFormatErroron malformed JSONself.datatype annotation (Dict->List[Dict])c2password.csv) with custom fields and edge casesFormatErrorcoverage (c2password-malformed.csv)test_importers_synologyandtest_import_synology_malformed_jsonBackward compatible: entries with no
Othersvalue or an empty one produce the same output as before.Existing
synology.csv/main.ymltests pass unchanged.