Sync upstream v0.4.9 + port proxmox-skill integration#1
Open
Skippy-the-Magnificent-one wants to merge 108 commits into
Open
Sync upstream v0.4.9 + port proxmox-skill integration#1Skippy-the-Magnificent-one wants to merge 108 commits into
Skippy-the-Magnificent-one wants to merge 108 commits into
Conversation
The Proxmox REST API has no endpoint for executing commands inside LXC
containers (unlike QEMU VMs which use the guest agent). This adds support
by SSHing to the Proxmox node and invoking .
Changes:
- config/models.py: Add SSHConfig model (user, port, key_file, password,
host_overrides, use_sudo) and attach it to the root Config
- tools/console/container_manager.py: New ContainerConsoleManager class
that verifies container state, opens a per-call paramiko SSH connection
to the appropriate node, and runs pct exec
- tools/containers.py: Add execute_command() method (single-target
selector); wire ContainerConsoleManager into ContainerTools.__init__
- tools/definitions.py: Add EXECUTE_CONTAINER_COMMAND_DESC
- server.py: Register execute_container_command tool; pass config.ssh to
ContainerTools
- pyproject.toml: Add paramiko>=3.0.0,<4.0.0 dependency
- tests/test_container_console.py: 7 unit tests covering success,
non-zero exit, stopped container, SSH failure, host_overrides,
use_sudo, and password auth fallback
…resent on PATH on the proxmox node
…h configuration and add documentation
Made-with: Cursor
Add `execute_container_command` tool
Implements robust support for distributing the server as a self-bootstrapping .mcpb bundle. Includes absolute import path normalization, automatic dependency installation via main.py wrapper, and enhanced configuration handling for MCP Hub environments (capitalization normalization, path injection). Also adds Github Actions CI for manifest validation. # Conflicts: # pyproject.toml # setup.py # src/proxmox_mcp/__init__.py # src/proxmox_mcp/server.py # src/proxmox_mcp/tools/containers.py # start_openapi.sh # tests/test_server.py
feat: add comprehensive MCP Bundle (.mcpb) support
Fix hatch wheel package selection for CI installs
Implement three new tools for LXC container management: - get_container_config: retrieves full configuration via Proxmox API - get_container_ip: extracts current IP addresses from interfaces - update_container_ssh_keys: injects or replaces root SSH keys These additions include a bug fix for SSH key path expansion, updated documentation, and comprehensive test coverage for both API-based and SSH-based tools.
Add [project.scripts] entry point in pyproject.toml and OpenCode configuration examples enabling users to run ProxmoxMCP-Plus directly from GitHub without cloning. *Co-authored with AI: OpenCode (ollama-cloud/glm-5)* Co-authored-by: OpenCode (ollama-cloud/glm-5) <noreply@opencode.ai> Co-authored-by: Michael Conrad <michael@newsrx.com>
feat: add LXC onboot and nesting options to create_container
* Add persistent job store and release v0.3.0 * Clean up root documentation layout * Fix CI typing issues for v0.3.0 release * Reject unknown Paramiko SSH host keys * Hide internal job route error details
Reorganize tests and docs support files
Prepare ProxmoxMCP-Plus v0.4.0 for release.
Release 0.4.1 with safer defaults and packaging/docs fixes.
feat(vm): add clone_vm MCP tool
Fix Home Assistant get_containers schema compatibility
Release 0.4.6 with API tunnel routing, cross-process job refresh, safer LXC retry persistence, safer snapshot rollback, and real-node storage status lookups.
…lease Release 0.4.7 streamable HTTP Docker mode
Merge release branch after CI and CodeQL passed.
Adds cluster-aware SSH routing, streaming exec, parallel node discovery, and real-time cluster monitoring -- ported from rodaddy/proxmox-skill (TypeScript) into this Python project. New modules: - core/cluster_ssh.py: Connect to primary node, Proxmox routes pct exec to the correct node automatically. Streaming + buffered exec modes. - core/node_discovery.py: Parallel multi-node container/VM discovery via asyncio + ThreadPoolExecutor. - tools/streaming_exec.py: MCP tools execute_container_command_streaming and execute_node_command with cluster-aware routing. - tools/monitor.py: MCP tool get_cluster_overview for real-time cluster snapshot (per-node resources + aggregate stats). Enhanced: - container_manager.py: Optional cluster-aware fallback when node is unknown or direct SSH fails. Fully backward-compatible. - Registered via plugin system (StreamingExecToolsPlugin, MonitorToolsPlugin) - SSH tools activate only when SSH is configured (matching existing pattern) - Monitor tools work without SSH (API-only for discovery) Attribution: https://github.com/rodaddy/proxmox-skill
Syncs rodaddy/ProxmoxMCP-Plus to RekklesNA v0.4.9 including: - Persistent job store and OpenAPI job routes - VM cloning tool - Container exec via SSH (PR #30) - Security hardening (command policy gateway) - Observability/metrics - Streamable HTTP Docker mode - Home Assistant schema compat - Plugin registry and tool registration system - PyPI and GHCR publishing - 14 releases worth of bug fixes and improvements
Adds cluster-aware SSH routing, streaming exec, parallel node discovery, and real-time cluster monitoring -- ported from rodaddy/proxmox-skill. New MCP tools: - execute_container_command_streaming (no node required) - execute_node_command (raw SSH to nodes) - get_cluster_overview (real-time cluster snapshot) Enhanced: - container_manager.py: cluster-aware fallback when node unknown - All registered via plugin system, backward-compatible Attribution: https://github.com/rodaddy/proxmox-skill
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 32693062 | Triggered | Generic Password | aedf48b | tests/test_container_console.py | View secret |
| 32693062 | Triggered | Generic Password | d280b3d | tests/test_container_console.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if self._ssh_config.strict_host_key_checking: | ||
| client.set_missing_host_key_policy(paramiko.RejectPolicy()) | ||
| else: | ||
| client.set_missing_host_key_policy(paramiko.AutoAddPolicy()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Part 1: Upstream sync (RekklesNA/ProxmoxMCP-Plus v0.4.9)
clone_vm)Part 2: rodaddy/proxmox-skill port (1,349 new lines)
Ported from rodaddy/proxmox-skill (TypeScript → Python):
core/cluster_ssh.pypct execautomaticallycore/node_discovery.pytools/streaming_exec.pyexecute_container_command_streaming+execute_node_commandtools/monitor.pyget_cluster_overview-- real-time cluster snapshotcontainer_manager.pyAll backward-compatible. SSH tools only activate when SSH is configured. Registered via plugin system.