New Contributing Guide#3135
Conversation
sspencerwire
left a comment
There was a problem hiding this comment.
Hi @metalllinux and thank you again for this. A couple of things:
- First, the front matter is missing in the CONTRIBUTING.md document. Minimum elements there should be:
Title:
author: - Second, it looks like you used AI for some of the coding (which I'm pretty sure we discussed openly in the channel.) That's fine, but can you add the disclaimer at the top that we discussed or something along those lines? I know it isn't technically policy yet, but I think there needs to be something there, and it needs to be at the beginning not at the end of the document.
- Third, I get that the
.pyspelling.ymland.markdownlint.ymlare in the root (i.e., ahead of the docs directory) but I think that CONTRIBUTING.md should be instead in the contributions section of the guides (docs/guides/contribute/) rather than in the root of the project.
*Fourth, to maintain file naming conventions that have already been established in the/docs/section, I think that rather than all capitals that the filename should becontributing.md
If you can justify the reasons for your documents as is, let me know.
Thank you again!
From the conversation in the Mattermost thread: https://chat.rockylinux.org/rocky-linux/pl/ud6d3z3mabgu88wu6ndrascz5r Hi @sspencerwire and again thank you ever so much for the review!
Ah, okay got it, so front matter needs to be included for all files, not just guides, books, labs and so on. I'll make sure to include that!
AI was used here that is correct. I made sure it was publicly known by the Documentation Team and the community in this thread initially when I started on this endeavour on creating the new CONTRIBUTING.md I want to be as open as possible! I didn't want anything to come as a surprise.
Absolutely and I'm glad that was brought up, that was one item I was unsure of regarding placing the disclaimer in core guiding docs like CONTRIBUTING.md. I'll make sure to add a disclaimer there as well.
Okay, thank you and will make the change.
Excellent and I will make that change as well. @wale - thank you kindly for your review and comments below:
Absolutely can see where you're coming from - anything core such as principles like CONTRIBUTING.md are fundamental to the Rocky Linux Docs and how the Docs work. It affects how users and maintainers interact with the Docs. I was initially very resistant from wanting to use AI for the creation of anything - I'm a person that likes to learn and to create and test things himself, that's how I got my start in the wonderful world of Linux and open source. However, in the IT / computing space, I've given in regarding that battle of resisting AI and have accepted that AI usage is now the norm from an efficiency standpoint and also from a quality of life point of view. I think it is inevitable that AI generated code will end up on the Docs site / across the Rocky Linux infrastructure in some way, shape or form. How that is handled, I'll gladly add my opinion and I'm happy we're discussing it but ultimately I'd like to leave and will accept the final decision of the Docs, Infra and all the other team leads. Another point I'd like to kindly highlight as well, I tracked the amount of hours I spent on this project and it was about 7 hours in total. That was going back and forth with the AI and making sure that human review was constantly kept in the chain and that improvements were made. This was not a project where I just placed what I wanted as a prompt into the AI and immediately pushed the end result as a commit without any human review. I've received enough AI documents in my time which have clearly not had any human review and that always irked me. That's why whenever I create anything with AI, I ensure it goes through human review and testing by myself first, before it is passed along to another person.
That is right @sspencerwire , it is similar in scope to the slurm document.
@wale - good points as well and I can see where you are coming from - there are a lot of dependencies depending on the OS you are using and I can see where that can cause confusion. For me, when testing (I went through the same steps for the slurm-rocky.md that I submitted yesterday), these did work for me. Great feedback and should I further edit CONTRIBUTING.md so that it more clearly says that the steps are a suggestion, rather than a mandatory setup and that ultimately the local setup should be what the end user is comfortable with? Apologies for the long post here and I was replying to all of the excellent points raised. Thank you both so much! |
6712fd5 to
cab5ec5
Compare
Adds a comprehensive contributing guide at docs/guides/contribute/contributing.md covering environment setup, validation tools, formatting guidelines, and PR workflow for Rocky Linux 10, 9, 8, macOS, and Windows contributors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cab5ec5 to
0f5631b
Compare
|
@sspencerwire and @wsoyinka - when you have a free cycle available, please take a look at the updated PR. I have added the following feedback and further refined by removing sections such as Steven's feedback:
Wale's feedback:
Your requests:
|
I've added the ai-contributors section in the front matter.
| ## Welcome | ||
|
|
||
| Thank you for your interest in contributing to the Rocky Linux documentation. This guide walks you through everything you need to create, edit, and submit documentation that meets our standards. | ||
|
|
There was a problem hiding this comment.
Hey @metalllinux leave out the table of contents section. First, internal links (within the document) will break when translated. Second, the table of contents is always available in the right-hand menu once the document is opened. This avoids problems when the document is translated. Second, the level 1 heading (Contributing to the Rocky Linux Documentation) is not needed as it will be picked up from the "Title:" meta entry. Third, once the document is renamed to expert_contributing.md the title should be something on the order of "An experts guide to contributing" or something along those lines. (again, this should replace what is currently in the "Title:" meta. Fourth, (and I can fix this on an editing pass) Sentence style capitalization for the headers would be "AI usage disclosure", "Quick start", "Fork and clone the repository", etc. Again, you don't necessarily need to fix that as I can fix it in an editing pass. Finally, at the end of the document where you are referencing other documents within documentation, these can and should be done by backing up and referencing them, rather than with a full URL. I can fix this as well in editing, I just want you to be aware.
There was a problem hiding this comment.
Hey @metalllinux leave out the table of contents section. First, internal links (within the document) will break when translated. Second, the table of contents is always available in the right-hand menu once the document is opened. This avoids problems when the document is translated. Second, the level 1 heading (Contributing to the Rocky Linux Documentation) is not needed as it will be picked up from the "Title:" meta entry. Third, once the document is renamed to
expert_contributing.mdthe title should be something on the order of "An experts guide to contributing" or something along those lines. (again, this should replace what is currently in the "Title:" meta. Fourth, (and I can fix this on an editing pass) Sentence style capitalization for the headers would be "AI usage disclosure", "Quick start", "Fork and clone the repository", etc. Again, you don't necessarily need to fix that as I can fix it in an editing pass. Finally, at the end of the document where you are referencing other documents within documentation, these can and should be done by backing up and referencing them, rather than with a full URL. I can fix this as well in editing, I just want you to be aware.
Brilliant and thank you for the further edits there Steven and I will have those incorporated!
There was a problem hiding this comment.
@sspencerwire - thank you and I have made the requested changes.
- Rename contributing.md to expert_contributing.md - Update title to "An expert's guide to contributing" - Remove Table of Contents (breaks during translation) - Remove H1 heading (picked up from title: meta entry) - Apply sentence-style capitalization to all headers - Remove all internal anchor links (translation incompatible) - Add warm welcome section with community support messaging - Make clear the tooling setup is optional, not required - Reference beginner guide as starting point for new contributors - Add Zed editor to graphical editors list - Replace all docs.rockylinux.org URLs with relative references - Add git update-index --assume-unchanged for .pyspelling.yml overrides to prevent accidental commits Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Test results for 9875c4e:
|
|
I missed this in the conversation, but there should have been no reason (that I can think of) why |
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)
Summary
CONTRIBUTING.mdguide for Rocky Linux documentation contributors.pyspelling.ymlconfiguration for spell checking with hunspell.markdownlint.ymlto allow<details>and<summary>HTML elements used in documentationDetails
The Contributing Guide includes:
Test plan
🤖 Generated with Claude Code