base will run timers and stop timers - with errors#20
Open
chevalier88 wants to merge 6 commits intorocketacademy:mainfrom
Open
base will run timers and stop timers - with errors#20chevalier88 wants to merge 6 commits intorocketacademy:mainfrom
chevalier88 wants to merge 6 commits intorocketacademy:mainfrom
Conversation
michelle-mok
reviewed
Sep 6, 2021
michelle-mok
left a comment
michelle-mok
left a comment
There was a problem hiding this comment.
good work using setInterval and organising your code into functions!
consider using more comments to make your code easier to follow for the reader
Comment on lines
+13
to
+20
| <span class="word" id="elapsed">Time Elapsed: </span> | ||
| <div class="row"> | ||
| <span class="word" id="time-left">Time Left: </span> | ||
| </div> | ||
| <div class="row"> | ||
| <span class="word" id="start">Start</span> | ||
| <span class="word" id="stop"></span> | ||
| <span class="word" id="reset"></span> |
There was a problem hiding this comment.
these should be created is script.js using DOM
Comment on lines
+33
to
+38
| let cardColor; | ||
| if (currentSymbol === '♥️' || currentSymbol === '♦️') { | ||
| cardColor = 'red'; | ||
| } else { | ||
| cardColor = 'black'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment? 7
Please fill in one error and/or error message you received while working on this assignment.
What part of the assignment did you spend the most time on?
Comfort Level (1-5): 2
Completeness Level (1-5): 1
What did you think of this deliverable? challenging
Is there anything in this code that you feel pleased about? the countdown + elapsed timer, but it's not completely working