Open
Conversation
Contributor
samklq
commented
Dec 7, 2022
samklq
commented
- Create CoursePage and BatchPage models
- Create CoursePage and BatchPage factories, set up wagtail site as fixture for use in unit tests
- Write unit tests for CoursePage and BatchPage models
- Create templates for course and batch pages, for viewing in student app
rocketkai
approved these changes
Dec 7, 2022
Contributor
rocketkai
left a comment
rocketkai
left a comment
There was a problem hiding this comment.
Awesome work!!! Onward!!! 💪💪💪
| batch=SubFactory(BatchFactory, swe_fundamentals=True) | ||
| ) | ||
|
|
||
| coding_bootcamp = Trait( |
Contributor
There was a problem hiding this comment.
Might be safer to name coding_bootcamp swe_bootcamp instead, to anticipate future bootcamp courses like Data Science bootcamp.
- Create CoursePage and BatchPage models - Create CoursePage and BatchPage factories, set up wagtail site as fixture for use in unit tests - Write unit tests for CoursePage and BatchPage models - Create templates for course and batch pages, for viewing in student app
samklq
force-pushed
the
3602796543_set_up_cms_with_wagtail
branch
from
8ad73e7 to
5367b34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.