Make sure that make_options contain useful input #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An encountered error case was make_options = "''"
doudou
reviewed
Feb 27, 2019
| test_options = [1] | ||
| test_options << Autobuild::Orogen.transports.join(" ") | ||
| make_options = make_options.join("' '") | ||
| if make_options =~ /[a-zA-Z0-9]/ |
Member
There was a problem hiding this comment.
This way you test for "useful input" looks very weird. Unless invoke_make_parallel is broken, the one normal case where the problem you noticed would happen is if make_options is empty. Would that be the case ? If yes, maybe just test for it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An encountered error case was make_options = "''" while testing orocos.rb with Travis