Conversation
also fixed test.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub fn part_two(input: &str) -> Option<u64> { | ||
| let (starts, ends, _ids) = parse(input); | ||
|
|
||
| Some(starts.into_iter().zip(ends).map(|(s, e)| { e-s +1 }).sum()) |
There was a problem hiding this comment.
part_two currently always returns the summed length of the merged ranges as Some(...), but day5_test_part_two asserts that the function should return None. With the example input in data/examples/05.txt this code returns Some(14), so running cargo test --bin 05 day5_test_part_two will consistently fail. Update the function or the test so the expected value matches the implemented behavior.
Useful? React with 👍 / 👎.
1 participant
No description provided.