Clock and hub status by Roxie222 · Pull Request #76 · robototes/REBUILT2026

Roxie222 · 2026-03-01T02:37:36Z

No description provided.

gemini-code-assist · 2026-03-01T02:37:49Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new utility class, ClockAndHubStatus, designed to centralize the logic for determining the active state of game-specific field elements and calculating dynamic target locations for the robot. This class integrates with the DriverStation to interpret match timing and game data, providing crucial information for autonomous and teleoperated strategies.

Highlights

New Utility Class: Introduced a new utility class, ClockAndHubStatus, to centralize game-specific timing and field element status logic.
Hub Activity Logic: Implemented a robust isHubActive method that determines the active state of a game 'hub' based on match time, alliance, and game-specific data from the DriverStation.
Dynamic Target Location: Added a getTargetLocation method to provide dynamic target coordinates for the robot, considering hub activity, alliance, and the robot's current pose.

Changelog

src/main/java/frc/robot/util/ClockAndHubStatus.java
- Added a new utility class ClockAndHubStatus.
- Implemented methods to check hub activity based on match time and game data.
- Included logic to determine target locations on the field.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new utility class ClockAndHubStatus for game-specific logic related to match time and hub status. A critical security vulnerability was identified in the isGameDataValid method, where an empty game data string could cause a StringIndexOutOfBoundsException, leading to a denial-of-service by crashing the robot's control program. Beyond this, a significant logic flaw in getTargetLocation was found, which could prevent compilation or cause incorrect behavior. There are also opportunities to improve code clarity and maintainability by removing unused code, defining magic numbers as constants, and improving coordinate point declarations.

I am having trouble creating individual review comments. Click here to see my feedback.

src/main/java/frc/robot/util/ClockAndHubStatus.java (18-50)

The logical structure of getTargetLocation is flawed and will likely result in a compilation error (e.g., unreachable code) or incorrect runtime behavior. The if (AllianceUtils.isRed()) block is followed by a separate if (AllianceUtils.isBlue()) block, instead of being chained with else if. This means after returning a value in the red alliance case, the code would attempt to continue execution, which is not valid. The method should be restructured to use a proper if-else if-else chain for checking the alliance.

    public Translation2d getTargetLocation(CommandSwerveDrivetrain drivetrain){
        if(isHubActive(0)){
            return AllianceUtils.getHubTranslation2d();
        }
        else {
            if(AllianceUtils.isRed()){
                if(drivetrain.getState().Pose.getX() <= Units.inchesToMeters(158.6)){
                    return AllianceUtils.getHubTranslation2d();
                }
                else if(drivetrain.getState().Pose.getY() >= Units.inchesToMeters(317.7/2)){
                    return pointLeftFieldTop;
                }
                else{
                    return pointLeftFieldBottom;
                }
            } else if (AllianceUtils.isBlue()){
                if(drivetrain.getState().Pose.getX() >= Units.inchesToMeters(651.2-158.6)){
                    return AllianceUtils.getHubTranslation2d();
                }
                else if(drivetrain.getState().Pose.getY() >= Units.inchesToMeters(317.7/2)){
                    return pointRightFieldBottom;
                }
                else{
                    return pointRightFieldTop;
                }
            } else {
                return AllianceUtils.getHubTranslation2d();
            }
        }
    }

src/main/java/frc/robot/util/ClockAndHubStatus.java (111-124)

The method isGameDataValid is vulnerable to a StringIndexOutOfBoundsException because it calls gameData.charAt(0) without checking if gameData is empty. If DriverStation.getGameSpecificMessage() returns an empty string (e.g., if game data isn't received from FMS), this will crash the robot's control program, leading to a denial of service during a match. A guard clause is needed to prevent this, and the logic can also be simplified for better readability.

    public boolean isGameDataValid(){
        String gameData = DriverStation.getGameSpecificMessage();
        if (gameData.isEmpty()) {
            return false;
        }
        switch (gameData.charAt(0)) {
            case 'R' :
            return true;
            case 'B' :
             return true;
            default : {
            return false;
            }
        }

    }

src/main/java/frc/robot/util/ClockAndHubStatus.java (4)

This import edu.wpi.first.wpilibj2.command.Command is not used in the file and can be removed.

src/main/java/frc/robot/util/ClockAndHubStatus.java (11)

The field matchLength is not used anywhere in the class and can be removed to clean up the code.

src/main/java/frc/robot/util/ClockAndHubStatus.java (13-16)

These Translation2d fields should be declared as private static final constants since their values do not change. Additionally, their names (pointLeftFieldTop, etc.) are ambiguous. Consider renaming them to reflect which alliance they are for, to improve clarity (e.g., RED_ALLIANCE_FALLBACK_TOP). The indentation for these lines is also inconsistent with the rest of the class and should be fixed.

    private static final Translation2d pointLeftFieldTop = new Translation2d(2,2);
    private static final Translation2d pointLeftFieldBottom = new Translation2d(2,6);
    private static final Translation2d pointRightFieldTop = new Translation2d(14,2);
    private static final Translation2d pointRightFieldBottom = new Translation2d(14,6);

src/main/java/frc/robot/util/ClockAndHubStatus.java (90-108)

The isHubActive method uses several "magic numbers" for match time thresholds (e.g., 130, 105, 80, 55, 30). These numbers make the code harder to read and maintain. It's better to define them as private static final constants with descriptive names at the top of the class. This also applies to the field dimensions used in getTargetLocation (e.g., 158.6, 317.7, 651.2).

iamawesomecat · 2026-03-01T09:41:57Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new utility class "ClockAndHubStatus" to manage game-specific logic, determining target locations and tracking hub status based on game time and alliance. A security review identified a potential Denial of Service (DoS) vulnerability in the "isGameDataValid" method, where an unhandled empty string from the Field Management System (FMS) could cause the robot code to crash. Additionally, my review suggests improving code clarity and maintainability by refactoring confusing control flow and extracting magic numbers into named constants.

src/main/java/frc/robot/util/ClockAndHubStatus.java

src/main/java/frc/robot/util/LauncherConstants.java

src/main/java/frc/robot/util/HubShiftUtil.java

…ClockAndHubStatus

…ILT2026 into ClockAndHubStatus

…ClockAndHubStatus

…ILT2026 into ClockAndHubStatus

RobototesProgrammers · 2026-03-06T09:34:52Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces HubShiftUtil to manage game clock and hub status during different phases of the match. It also updates LauncherConstants to provide necessary time-of-flight data. The overall logic is sound, and the identified areas in the new HubShiftUtil class for simplification and maintainability have been retained as they align with general best practices and do not contradict any specific repository rules.

src/main/java/frc/robot/util/HubShiftUtil.java

…ClockAndHubStatus

…ILT2026 into ClockAndHubStatus

markpete · 2026-03-20T23:06:59Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+    if (!winOverride.isEmpty()) {
+      return winOverride.get()
+          ? (alliance == Alliance.Blue ? Alliance.Red : Alliance.Blue)
+          : (alliance == Alliance.Blue ? Alliance.Blue : Alliance.Red);


Isn't this line redundant? Just return alliance in this case.

src/main/java/frc/robot/util/HubShiftUtil.java

src/main/java/frc/robot/Robot.java

Removed unnecessary merge conflict markers from imports.

…ClockAndHubStatus

…ILT2026 into ClockAndHubStatus

markpete · 2026-03-30T23:42:58Z

src/main/java/frc/robot/sensors/LEDSubsystem.java

    setHardwareColor(color);

-    currentPatternPub.set("SOLID");
+    currentPatternPub.set(currentPattern.name());


[nit] I don't think you need the currentPattern variable. You can just do:

currentPatternPub.set(LEDPattern.SOLID.name());

markpete · 2026-03-30T23:43:34Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+import lombok.Setter;
+
+public class ClockAndHubStatus {
+  public double matchLength = 2.5;


Please add a comment with units. Is this minutes?

markpete · 2026-03-30T23:44:31Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+public class ClockAndHubStatus {
+  public double matchLength = 2.5;
+
+  private Translation2d pointLeftFieldTop = new Translation2d(2, 6);


Should the field variables be in a Field.java file? Will other subsystems want or need this info?

markpete · 2026-03-30T23:44:55Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+  private double allianceLineX = Units.inchesToMeters(158.6);
+  private double robotOffset = Units.inchesToMeters(15);
+
+  private static final double TRANSITION_PERIOD_END_TIME = 130;


Add a comment with units. (seconds?)

markpete · 2026-03-30T23:48:09Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+    }
+
+    if (AllianceUtils.isBlue()) {
+      if (drivetrain.getState().Pose.getX() <= allianceLineX + robotOffset) {


Call drivetrain.getState().Pose once. It can change each time you call it in this if() tree.

Pose2d currentPose = drivetrain.getState().Pose; if (currentPose.getX() <= allianceLineX + robotOffset) { ... } else if (currentPost.getY() >= (fieldWidth / 2)) {

markpete · 2026-03-30T23:49:06Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+    }
+  }
+
+  /** Starts the timer at the begining of teleop. */


[nit] spelling: "beginning"

markpete · 2026-03-31T00:00:07Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+        // If we have invalid game data, assume hub is active.
+        return true;
+      }
+    }


Code beyond this point is not reachable as the routine will return from this switch statement regardless of the value of gameData.charAt(0).

markpete · 2026-03-31T00:04:21Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces the ClockAndHubStatus utility for match-time-based logic and refactors HubShiftUtil to use a more dynamic shift adjustment system. It also implements an autoShoot trigger in Controls and centralizes NetworkTables state publishing within LEDSubsystem. Review feedback highlights a critical logic error in ClockAndHubStatus where premature returns bypass shift calculations, along with suggestions to remove an unnecessary utility class instantiation and redundant code in the LED and alliance logic.

gemini-code-assist · 2026-03-31T00:06:57Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+    if (message.length() > 0) {
+      char character = message.charAt(0);
+      if (character == 'R') {
+        return redInactiveFirst = true;
+      } else if (character == 'B') {
+        return redInactiveFirst = false;
+      }
+    }


The return statements here cause the isHubActive method to exit prematurely, skipping the match time-based logic that determines if the hub is active during different shifts. This logic should likely only set the redInactiveFirst flag and allow the method to continue to the shift calculations.

gemini-code-assist · 2026-03-31T00:06:57Z

src/main/java/frc/robot/Robot.java

    // continue until interrupted by another command, remove
    // this line or comment it out.
+
+    HubShiftUtil instance = new HubShiftUtil();


The instantiation of HubShiftUtil is unnecessary because the class is designed as a utility with static methods. You can call HubShiftUtil.initialize() directly without creating an instance.

gemini-code-assist · 2026-03-31T00:06:57Z

src/main/java/frc/robot/sensors/LEDSubsystem.java

+    currentPatternPub.set(currentPattern.name());
    currentColorPub.set(color.toHexString());
    alternatingColorsPub.set("A:None | B:None");


This manual publishing logic is redundant. Since setMode() calls publishState() at the end of its execution, and publishState() handles all these fields (including currentModePub which is missing here), these lines should be removed to maintain a single source of truth for NetworkTables updates.

gemini-code-assist · 2026-03-31T00:06:57Z

src/main/java/frc/robot/util/ClockAndHubStatus.java

+    if (!winOverride.isEmpty()) {
+      return winOverride.get()
+          ? (alliance == Alliance.Blue ? Alliance.Red : Alliance.Blue)
+          : (alliance == Alliance.Blue ? Alliance.Blue : Alliance.Red);


This ternary expression is redundant as it simply returns the alliance variable itself. It can be simplified to just alliance.

alliance

…ClockAndHubStatus

Nicole-N-Pedersen and others added 7 commits February 24, 2026 18:31

cereal found

e47d22c

ClockAndHubStatus

f926f42

kjefnkjdgn

9c1b260

Merge branch 'main' into ClockAndHubStatus

2c56ec3

?

4553cf1

ehkfshjjdfh

06f1470

Added translation2ds for points

dd000cb

spotlessapply

fea02d2

gemini-code-assist bot reviewed Mar 1, 2026

View reviewed changes

src/main/java/frc/robot/util/ClockAndHubStatus.java Outdated Show resolved Hide resolved

src/main/java/frc/robot/util/ClockAndHubStatus.java Show resolved Hide resolved

src/main/java/frc/robot/util/ClockAndHubStatus.java Outdated Show resolved Hide resolved

made HubShiftUtil

ad73efe

markpete requested changes Mar 3, 2026

View reviewed changes

Nicole-N-Pedersen and others added 11 commits March 3, 2026 19:16

hjfkshdjs

1701819

refactor cahs

41b13f3

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

7c30d42

…ClockAndHubStatus

spot

bac7a94

kgyygy

f3bb217

Merge branch 'ClockAndHubStatus' of https://github.com/robototes/REBU…

ce9fc0e

…ILT2026 into ClockAndHubStatus

mlkdvxmkld

c2f7b17

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

1e3e197

…ClockAndHubStatus

Merge branch 'ClockAndHubStatus' of https://github.com/robototes/REBU…

fb7d4cf

…ILT2026 into ClockAndHubStatus

cahs clean up

e660005

clean up

eab059d

gemini-code-assist bot reviewed Mar 6, 2026

View reviewed changes

src/main/java/frc/robot/util/HubShiftUtil.java Show resolved Hide resolved

src/main/java/frc/robot/util/HubShiftUtil.java Outdated Show resolved Hide resolved

markpete requested changes Mar 13, 2026

View reviewed changes

src/main/java/frc/robot/util/HubShiftUtil.java Outdated Show resolved Hide resolved

src/main/java/frc/robot/util/HubShiftUtil.java Outdated Show resolved Hide resolved

src/main/java/frc/robot/util/HubShiftUtil.java Show resolved Hide resolved

Jetblackdragon added 2 commits March 16, 2026 23:26

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

d619cc8

…ClockAndHubStatus

auto scoring

6c66dec

Nicole-N-Pedersen and others added 2 commits March 17, 2026 19:05

fdshkdsfkdfs

bc7b18f

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

046318f

…ClockAndHubStatus

RobototesProgrammers requested a review from markpete March 18, 2026 23:45

Nicole-N-Pedersen added 2 commits March 19, 2026 18:44

Merge branch 'ClockAndHubStatus' of https://github.com/robototes/REBU…

9ff4fcd

…ILT2026 into ClockAndHubStatus

Merge branch 'ClockAndHubStatus' of https://github.com/robototes/REBU…

4b7df61

…ILT2026 into ClockAndHubStatus

markpete requested changes Mar 20, 2026

View reviewed changes

Roxie222 and others added 9 commits March 26, 2026 18:49

change nt value

3c4eda3

Clean up imports in Robot.java

a2b7b52

Removed unnecessary merge conflict markers from imports.

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

bb92c92

…ClockAndHubStatus

changes

d00494f

spotless

51f1b1b

add rainbow back (well maybe it works)

0731102

this should work

ce812e4

z

294b378

Merge branch 'ClockAndHubStatus' of https://github.com/robototes/REBU…

13fb871

…ILT2026 into ClockAndHubStatus

markpete requested changes Mar 31, 2026

View reviewed changes

gemini-code-assist bot reviewed Mar 31, 2026

View reviewed changes

Jetblackdragon added 3 commits March 31, 2026 22:16

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

c4137e6

…ClockAndHubStatus

spot

1e6e2f4

Merge branch 'main' of https://github.com/robototes/REBUILT2026 into …

57de834

…ClockAndHubStatus

Conversation

Roxie222 commented Mar 1, 2026

Uh oh!

gemini-code-assist bot commented Mar 1, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

src/main/java/frc/robot/util/ClockAndHubStatus.java (18-50)

src/main/java/frc/robot/util/ClockAndHubStatus.java (111-124)

src/main/java/frc/robot/util/ClockAndHubStatus.java (4)

src/main/java/frc/robot/util/ClockAndHubStatus.java (11)

src/main/java/frc/robot/util/ClockAndHubStatus.java (13-16)

src/main/java/frc/robot/util/ClockAndHubStatus.java (90-108)

Uh oh!

iamawesomecat commented Mar 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobototesProgrammers commented Mar 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markpete commented Mar 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 31, 2026