Conversation
Contributor
Author
Closed
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logging for motor velocity, stator current, and supply current in the Feeder and Spindexer subsystems. The feedback recommends optimizing performance by using StatusSignal.refreshAll to batch refresh status signals, which reduces CAN bus traffic and CPU overhead compared to individual refreshes within the periodic methods.
markpete
previously requested changes
Mar 31, 2026
jamesdooley4
changed the title
Contributor
|
Publishing the key values should be enough instead of using data log and smartdashboard |
jamesdooley4
reviewed
Apr 5, 2026
Member
jamesdooley4
left a comment
jamesdooley4
left a comment
There was a problem hiding this comment.
Just need to fresh the velocity values along with the current values, to make most efficient use of the CAN bus
jamesdooley4
approved these changes
Apr 6, 2026
jamesdooley4
dismissed
markpete’s stale review
Stale review with comments addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.