Skip to content

refactor(fix): share repo root resolution helpers#575

Merged
wesm merged 1 commit intoroborev-dev:mainfrom
mariusvniekerk:bd-pui-7-fix-repo-root-helpers
Mar 24, 2026
Merged

refactor(fix): share repo root resolution helpers#575
wesm merged 1 commit intoroborev-dev:mainfrom
mariusvniekerk:bd-pui-7-fix-repo-root-helpers

Conversation

@mariusvniekerk
Copy link
Collaborator

Summary

  • extract shared helpers for worktree root, main repo root, and branch fallback resolution
  • reuse the helpers across fix list/open/batch/single-job flows and the matching compact path
  • add direct helper coverage for worktree and branch-filter behavior

Verification

  • go fmt ./...
  • go vet ./...
  • go test ./...
  • roborev fix --list --all-branches

Tracking

  • closes bd-pui.7

Deduplicate worktree root, main repo root, and branch fallback resolution across fix flows and the matching compact path.

Verified with:
- go fmt ./...
- go vet ./...
- go test ./...
- roborev fix --list --all-branches

🤖 Generated with [OpenAI Codex](https://openai.com/codex)
Co-authored-by: OpenAI Codex <noreply@openai.com>
@roborev-ci
Copy link

roborev-ci bot commented Mar 24, 2026

roborev: Combined Review (0747d9d)

Verdict: Clean. All agents agree no issues were found. The changes cleanly centralize current-repo/worktree root and
branch resolution logic without introducing new security risks.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit ed76ce9 into roborev-dev:main Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants