Skip to content

refactor(agent): unify preview and runtime arg builders#573

Merged
wesm merged 1 commit intomainfrom
bd-pui-5-agent-arg-builders
Mar 24, 2026
Merged

refactor(agent): unify preview and runtime arg builders#573
wesm merged 1 commit intomainfrom
bd-pui-5-agent-arg-builders

Conversation

@mariusvniekerk
Copy link
Collaborator

Summary

  • unify CommandLine previews and runtime argument assembly for codex, copilot, cursor, droid, and pi
  • keep preview-only sanitization explicit for repo paths, stdin markers, and resolved session paths
  • add regression tests covering preview/runtime splits and CommandLine alignment

Validation

  • go fmt ./...
  • go vet ./...
  • go test ./...
  • roborev fix --open --list

bd-pui.5

Share per-agent argument assembly between CommandLine previews and runtime builders while keeping preview-only omissions for repo paths, stdin markers, and resolved session paths.

Validation:
- go fmt ./...
- go vet ./...
- go test ./...
- roborev fix --open --list (no open jobs)

🤖 Generated with [OpenAI Codex](https://openai.com/codex)
Co-authored-by: OpenAI Codex <noreply@openai.com>
@roborev-ci
Copy link

roborev-ci bot commented Mar 24, 2026

roborev: Combined Review (b288808)

Verdict: All reviewers agree the code is clean and no issues were found.

The changes successfully refactor CLI
argument construction to unify preview and runtime argument builders across agent integrations while adding targeted tests to preserve intended omissions, without introducing any new security risks.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit 91aa26f into main Mar 24, 2026
8 checks passed
@wesm wesm deleted the bd-pui-5-agent-arg-builders branch March 24, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants