Skip to content

refactor(agent): share clone helpers across adapters#572

Merged
wesm merged 1 commit intoroborev-dev:mainfrom
mariusvniekerk:bd-pui-3-agent-config-cloning
Mar 24, 2026
Merged

refactor(agent): share clone helpers across adapters#572
wesm merged 1 commit intoroborev-dev:mainfrom
mariusvniekerk:bd-pui-3-agent-config-cloning

Conversation

@mariusvniekerk
Copy link
Collaborator

Summary

  • extract a small internal helper for cloning shared command/model/reasoning/agentic/session state across agent adapters
  • keep adapter-specific behavior local, including Pi provider handling and adapters without model/session support
  • add clone-chain coverage for session-bearing agents to lock preserved state behavior

Validation

  • go fmt ./...
  • go vet ./...
  • go test ./...
  • roborev fix --open --list

Extract shared clone-state helpers for command/model/reasoning/agentic/session fields across the command-backed agents and add coverage for session-bearing clone chains.

Validation:
- go fmt ./...
- go vet ./...
- go test ./...
- roborev fix --open --list

🤖 Generated with [OpenAI Codex](https://openai.com/codex)
Co-authored-by: OpenAI Codex <noreply@openai.com>
@roborev-ci
Copy link

roborev-ci bot commented Mar 24, 2026

roborev: Combined Review (65ba414)

Verdict: Clean - The refactor centralizing agent clone and
configuration logic into shared helpers preserves existing behavior, session state, and security boundaries with no issues found.

All agents agree the code is clean.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit 4adcf7f into roborev-dev:main Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants