Skip to content

refactor(agent): unify workflow resolution#571

Merged
wesm merged 1 commit intomainfrom
bd-pui-4-workflow-resolution
Mar 24, 2026
Merged

refactor(agent): unify workflow resolution#571
wesm merged 1 commit intomainfrom
bd-pui-4-workflow-resolution

Conversation

@mariusvniekerk
Copy link
Collaborator

Summary

  • add a shared workflow resolution helper for preferred agent, backup agent, and model selection
  • update fix, refine, review, daemon, CI, and batch callers to use the shared precedence path
  • add resolver coverage for alias-safe backup matching and preserving agent defaults without a backup model

Validation

  • go fmt ./...
  • go vet ./...
  • go test ./...
  • roborev fix --open --list

Shared workflow resolution now owns preferred-agent, backup-agent, and model selection precedence across fix, refine, review, daemon, and batch callers.

Validation: go fmt ./... && go vet ./... && go test ./... && roborev fix --open --list

🤖 Generated with [OpenAI Codex](https://openai.com/codex)
Co-authored-by: OpenAI Codex <noreply@openai.com>
@roborev-ci
Copy link

roborev-ci bot commented Mar 24, 2026

roborev: Combined Review (cb3e1c0)

Verdict: All agents agree the code is clean and no issues were found.

This change centralizes workflow agent/model resolution into a reusable WorkflowConfig struct, eliminating duplicated logic across CLI commands and daemon workers without introducing new trust boundaries or security regressions.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit c4c1f3d into main Mar 24, 2026
8 checks passed
@wesm wesm deleted the bd-pui-4-workflow-resolution branch March 24, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants