Skip to content

refactor(tui): normalize HTTP loaders and tea wrappers#570

Merged
wesm merged 1 commit intomainfrom
bd-pui-2-tui-http-loading
Mar 24, 2026
Merged

refactor(tui): normalize HTTP loaders and tea wrappers#570
wesm merged 1 commit intomainfrom
bd-pui-2-tui-http-loading

Conversation

@mariusvniekerk
Copy link
Collaborator

Summary

  • route repeated TUI jobs, repos, branches, patch, and job-detail fetches through shared synchronous loaders
  • keep Bubble Tea message construction explicit in the command wrappers while reusing the loader layer
  • reuse shared transport helpers for patch text loading and fix-job patch/job lookup

Verification

  • go fmt ./...
  • go vet ./...
  • go test ./...
  • go test ./cmd/roborev/tui/...
  • roborev fix --open --list

Route repeated TUI HTTP fetches through shared synchronous loaders while keeping message construction explicit in the Bubble Tea commands.

Verification:
- go fmt ./...
- go vet ./...
- go test ./...
- go test ./cmd/roborev/tui/...
- roborev fix --open --list (no open jobs)

🤖 Generated with [OpenAI Codex](https://openai.com/codex)
Co-authored-by: OpenAI Codex <noreply@openai.com>
@roborev-ci
Copy link

roborev-ci bot commented Mar 24, 2026

roborev: Combined Review (1a459eb)

Verdict: All reviewers agree the code is clean.

The
refactoring safely consolidates TUI HTTP-fetch logic into shared loader helpers without introducing any behavioral or security regressions. No issues were found.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit 5bd7a8e into main Mar 24, 2026
8 checks passed
@wesm wesm deleted the bd-pui-2-tui-http-loading branch March 24, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants