Fix for speedtest.sh execution permissions issue in Docker container#24
Open
NicksonYap wants to merge 1 commit intorobinmanuelthiel:mainfrom
Open
Fix for speedtest.sh execution permissions issue in Docker container#24NicksonYap wants to merge 1 commit intorobinmanuelthiel:mainfrom
speedtest.sh execution permissions issue in Docker container#24NicksonYap wants to merge 1 commit intorobinmanuelthiel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @robinmanuelthiel thanks for the wonderful Dockerfile project, it's really useful!
For non -nix based Docker hosts (I'm using Windows with WSL 2)
or that when the project is cloned, the ``speedtest.sh` file tends not to carry the executable permission
hence I added a command to
chmodit within the Docker container to make sure the executable permission is set within the Docker container / imageThanks!