Pull Request; added User Shops and AAA#21
Open
themeels wants to merge 4 commits into
Open
Conversation
Updated Dice’s Search Helper to include: User Shops Almost Abandoned Attic (see README)
jujaga
reviewed
Aug 10, 2023
| Adds search icons under items in various areas. | ||
| Almost Abandoned Attic is tricky because the image and text are linked to each other in the No Haggle option. To use the Search Helper icons in the Attic, hit "Cancel" and the link will open. | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
If we're going to be adding a readme image to this, the image should be hosted as an asset in the git repository directly, or as a public image like on imgur.
Author
There was a problem hiding this comment.
Not 100% sure how one would add it as an hosted asset to the git repository, would it just need to be added by Dice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added User Shops and Almost Abandoned Attic. Created README file for guidance on using in the Attic as it’s not perfect due to the differences in the way that shop functions.