Add code to link remote and local paths.#212
Open
rsekman wants to merge 7 commits intorndusr:masterfrom
Open
Conversation
Owner
|
That's much simpler than I thought it would be.
Looks like it should be working great.
|
raise ValueError if not possible
When adding a torrent like 'stig add my.torrent --path /path/to/directory' links were not respected. That is, stig would always interpret /path/to/directory as a local path, even if it should be translated to a remote path before being sent to transmission.
|
|
||
| DUMP_WIDTH = 79 | ||
|
|
||
| async def run(self, REMOTE, LOCAL, force): |
There was a problem hiding this comment.
Is there any reason this needs to be async? Every nested scope this coroutine would generate appears to use blocking methods.
Owner
|
IIRC, run() can be either sync or async. This run() doesn't seem to use the
async event loop, so it probably should be sync.
But does it matter?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #211. See
stig -h link.At the moment only takes effect for the
movecommand, but that may be the most frequently used. Only absolute paths are allowed in links, so relative paths should pass transparently through move, but I haven't tested this.It would be nice to have local path/remote path fields in the various torrent views; this shouldn't be too difficult.