test(wiring): fix master CI — add perf.v8_inspector_targets to canonical tool names#96
Merged
Merged
Conversation
The node-runtime skill legitimately references perf.v8_inspector_targets (registered in internal/core/tools/perf/v8.go) to enumerate V8 inspector targets before profiling, but the hand-maintained canonicalToolNames fixture in skills_test.go never included it — so TestSkillToolRefsAreValid flagged it as an unknown tool and turned master CI red. Signed-off-by: rlaope <piyrw9754@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSkillToolRefsAreValidflaggedperf.v8_inspector_targetsas an unknown tool referenced by thenode-runtimeskill.internal/core/tools/perf/v8.goand used by the skill to enumerate V8 inspector targets before capturing a CPU profile. The gap was in the test's hand-maintainedcanonicalToolNamesfixture, which hadperf.v8_inspector_cpu_profilebut notperf.v8_inspector_targets.Test plan
go test -race -count=1 ./internal/wiring/...passes locallyallowed_toolsagainst the canonical list —perf.v8_inspector_targetswas the only missing entry