fix(cli): cloudy tools parity with ask + document Docker/correlate tools#109
Merged
Conversation
cloudy tools hand-built wiring.Options and omitted docker_hosts / argocd / alertmanager, so it under-reported the change / metric / log.container / gitops / alert groups versus what `cloudy ask` actually runs. Route it through wiring.Rebuild — the single owner of full-Options registry construction — so the report matches runtime. Found via live QA. Signed-off-by: rlaope <piyrw9754@gmail.com>
Add the change / metric / correlate tool groups and log.container to the README tool table and Backends table (Docker, Change, Correlation domains), and record them plus the cloudy tools parity fix in the v0.5.0 changelog. Signed-off-by: rlaope <piyrw9754@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found via live QA against a real kind cluster + Docker daemon:
cloudy toolsunder-reported the tool registry versus whatcloudy askactually runs.cloudy toolshand-builtwiring.Optionsand omitteddocker_hosts/argocd/alertmanager, so it showedchange/metric/log.container/gitops/alertas skipped even when configured. Route it throughwiring.Rebuild(the single owner of full-Options registry construction, already used bycloudy ask) so the report matches runtime.cloudy askwas unaffected — it already usedRebuild.change/metric/correlategroups andlog.containerin the README tool table + Backends table (adds Docker / Change / Correlation domains), and record them + the fix in the v0.5.0 changelog.Live QA evidence (read-only, real infra)
cloudy toolsbefore fix (withdocker_hostsset):metric/log.containershown skipped ✗change.recent,metric.container_stats,log.container,correlate.workloadall ok ✓Test plan
go build ./...go test ./internal/ui/cli/... ./internal/wiring/...golangci-lint v2.12 run ./internal/ui/cli/...→ 0 issues;gofmtcleancloudy toolsnow matchescloudy askregistration against a real cluster + Docker hostOut of scope (separate finding, not fixed here)
cloudy doctor's "kubeconfig parseable" check loads~/.cloudy/config.yamland parses it as a kubeconfig (json: cannot unmarshal string into Config.contexts of type v1.NamedContext) — a pre-existing doctor bug unrelated to the new tools. Worth a follow-up.🤖 Generated with Claude Code