JobCountByQueueAndState: fix empty queue parity, coverage#1140
Merged
JobCountByQueueAndState: fix empty queue parity, coverage#1140
Conversation
brandur
approved these changes
Feb 7, 2026
`JobCountByQueueAndState` returned inconsistent results across drivers when callers requested queues with no matching jobs. PostgreSQL returned those requested queues with zero counts because the query materialized an `all_queues` CTE, while SQLite needed wrapper-level fill-in to produce the same rows. This change keeps the SQLite `sqlc` query for counting existing queues, but makes the wrapper complete missing requested queues so behavior is aligned. It also defines deduplicated queue-name semantics consistently: PostgreSQL now uses `DISTINCT` in `all_queues`, and SQLite deduplicates its sorted input in the wrapper to match. Driver conformance coverage now explicitly checks missing requested queues and deduplicated queue-name input for `JobCountByQueueAndState`, so parity stays enforced across drivers. Fixes riverqueue/riverui#496.
bgentry
force-pushed
the
bg/missing-job-count-driver-test-coverage
branch
from
398179d to
15aa344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JobCountByQueueAndStatereturned inconsistent results across drivers when callers requested queues with no matching jobs. PostgreSQL returned those requested queues with zero counts because the query materialized anall_queuesCTE, while SQLite needed wrapper-level fill-in to produce the same rows.This change keeps the SQLite
sqlcquery for counting existing queues, but makes the wrapper complete missing requested queues so behavior is aligned. It also defines deduplicated queue-name semantics consistently: PostgreSQL now usesDISTINCTinall_queues, and SQLite deduplicates its sorted input in the wrapper to match.Driver conformance coverage now explicitly checks missing requested queues and deduplicated queue-name input for
JobCountByQueueAndState, so parity stays enforced across drivers.Fixes riverqueue/riverui#496.