Fix OSC listener settings control#6
Conversation
Signed-off-by: Alberto Aguilar <carlos.aguilarlopez@ucr.ac.cr>
Signed-off-by: Alberto Aguilar <carlos.aguilarlopez@ucr.ac.cr>
Additional fix included: slice display fullscreen sizing on WindowsWhile testing the OSC listener fix on the updated BugWhen opening a slice display on a selected physical monitor, the output window was created on the correct display but did not fill the full screen area. On a 1920×1080 display, the slice window was rendered smaller than the physical output area, leaving visible desktop space around the right/bottom edges. Measured from the slice display DevTools: Expected: The incoming slice frames were already correct at FixThe slice display window now uses - fullscreen: isSliceWin ? true : fullscreen,
+ kiosk: isSliceWin,
+ fullscreen: isSliceWin ? false : fullscreen,Additionally, after Electron creates the slice window, the content bounds are explicitly matched to the selected display bounds: try { newWindow.setMenuBarVisibility(false); } catch { /* */ }
try {
const display = screen.getDisplayMatching(newWindow.getBounds());
const b = display.bounds;
newWindow.setContentBounds({
x: b.x,
y: b.y,
width: b.width,
height: b.height,
});
} catch { /* best-effort projector sizing */ }With both changes applied, the same display correctly reports: Updated branch statusThis branch has been rebased/recreated on top of |
Summary
This PR fixes the OSC listener control in Settings by replacing the hidden toggle with a visible button.
In the packaged desktop app, the OSC backend was already present and functional, but the Settings UI did not provide a usable visible control to start or stop the listener. As a result, the UDP listener was never started from the UI.
Verification
Tested on Windows desktop build:
Listening.netstat -ano -p UDP | findstr :8000confirms the app is listening on UDP port 8000./preset/0with value1.0correctly triggers the mapped preset.Also ran:
Result:
Notes
The existing warnings are unrelated to this change.