feat: Video Player Audio Enhancement (#119)#631
Open
omonxooo-commits wants to merge 2 commits into
Open
Conversation
This PR pushes the latest fixes for test failures and updates study group state handling. Changes: - Guard `scrollIntoView` in `GroupDiscussionThread` for JSDOM tests. - Keep leaderboard and group query results in sync with persisted storage in `useStudyGroups`. - Stabilize async validation promise handling in `AsyncValidationManager`. - Fix path imports in `TipForm` tests for the current test environment.
- Add useAudioEnhancement hook using Web Audio API - Bass boost via low-shelf BiquadFilter @ 100 Hz - Voice clarity via peaking BiquadFilter @ 3 kHz - Noise reduction via GainNode attenuation - Lazy graph init on first toggle (respects autoplay policy) - Add AudioEnhancement UI component with toggle + sliders - Expose audioEnhancement via VideoPlayerContext - Integrate into AdvancedVideoPlayer and VideoPlayer - Add 'E' keyboard shortcut to toggle enhancement
omonxooo-commits
force-pushed
the
feat/audio-enhancement-issue-119
branch
from
639cc68 to
5b1464f
Compare
|
@omonxooo-commits Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Audio Enhancement for the Video Player as described in issue #517.
Changes
useAudioEnhancementhook — Web Audio API signal chain: bass boost (low-shelf BiquadFilter @ 100 Hz), voice clarity (peaking BiquadFilter @ 3 kHz), noise reduction (GainNode). Graph is lazily initialized on first toggle to respect browser autoplay policy.AudioEnhancementcomponent — Toggle button in the controls bar (highlights blue when active) with a dropdown panel containing enable/disable switch and sliders for Bass Boost, Voice Clarity, and Noise Reduction.VideoPlayerContext— AddedaudioEnhancementfield to the context interface.AdvancedVideoPlayer&VideoPlayer— Hook wired up, context updated, component rendered next to PlaybackControls,Ekeyboard shortcut added to toggle enhancement.Acceptance Criteria
Eto toggleCloses #517