Fix test failures and sync issue in study group utilities#627
Open
omonxooo-commits wants to merge 1 commit into
Open
Fix test failures and sync issue in study group utilities#627omonxooo-commits wants to merge 1 commit into
omonxooo-commits wants to merge 1 commit into
Conversation
This PR pushes the latest fixes for test failures and updates study group state handling. Changes: - Guard `scrollIntoView` in `GroupDiscussionThread` for JSDOM tests. - Keep leaderboard and group query results in sync with persisted storage in `useStudyGroups`. - Stabilize async validation promise handling in `AsyncValidationManager`. - Fix path imports in `TipForm` tests for the current test environment.
|
Hey @omonxooo-commits! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pushes the latest fixes for test failures and updates study group state handling.
Changes:
scrollIntoViewinGroupDiscussionThreadfor JSDOM tests.useStudyGroups.AsyncValidationManager.TipFormtests for the current test environment.Description
Brief description of changes
Related Issue
Closes #
Type of Change
Checklist