Feature/349 animation request animation frame#516
Open
Benedict315 wants to merge 2 commits into
Open
Conversation
…rame (rinafcode#349) - Add animationScheduler utility with requestAnimationFrame-based timing - Update useLongPress hook to use rAF for gesture timing - Update useGestures (double-tap) hook to use rAF for timing - Update OfflineIndicatorProvider toast dismissals to use scheduleAnimationFrame - Update MobileVideoPlayer auto-hide to use scheduleAnimationFrame - Add comprehensive animation scheduling documentation - Ensure animations sync with browser refresh rate for 60fps performance - Replace setTimeout with requestAnimationFrame for animation-related timing This change improves animation smoothness and frame scheduling by using requestAnimationFrame instead of setTimeout for animation-related operations.
|
@Benedict315 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict and fix workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch: feature/349-animation-requestAnimationFrame has been created and pushed to origin.
Changes Made:
Created animation scheduler utility (src/utils/animationScheduler.ts) with requestAnimationFrame-based timing functions
Updated gesture hooks to use rAF for timing:
useLongPress.ts - replaced setTimeout with requestAnimationFrame for long press detection
useGestures.ts - replaced setTimeout with requestAnimationFrame for double-tap detection
Updated UI components to use the animation utility:
OfflineIndicatorProvider.tsx - toast dismissals now use scheduleAnimationFrame
MobileVideoPlayer.tsx - auto-hide controls now use scheduleAnimationFrame
Added comprehensive documentation (docs/ANIMATION_SCHEDULING.md) with best practices for animation scheduling
closes #349