feat: migrate forms to react-hook-form for minimal re-renders#510
Open
chucksentertainment-hash wants to merge 1 commit into
Open
Conversation
- Install react-hook-form@7.56.4
- MobileFormInput: make value/onChangeText optional to support Controller
- MobileLogin: replace useState fields with useForm + Controller; move
server errors to separate serverError state; load remembered email via
setValue
- MobileRegister: replace useState fields + manual validate() with
useForm + Controller; use watch('password') for confirm validation;
remove useFormCache prefill (simplified)
- MobileProfile edit form: replace five useState edit fields with
useForm + Controller; replace manual validateForm() with RHF rules;
replace persistFields with cacheFormValues on submit
Resolves: form typing lag caused by full re-render on every keystroke
|
@chucksentertainment-hash Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict and fix workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: form typing lag caused by full re-render on every keystroke
closes #370