feat: animation state machine for predictable animation lifecycle#496
Merged
RUKAYAT-CODER merged 4 commits intoMay 30, 2026
Merged
Conversation
- Add useAnimationStateMachine hook (CLOSED/OPENING/OPEN/CLOSING) - Pure reducer — illegal transitions are no-ops, preventing race conditions - Refactor FilterSheet to use the state machine: - open() only fires from CLOSED or CLOSING states - close() only fires from OPEN or OPENING states - isVisible drives Modal mount (stays mounted during CLOSING animation) - ANIMATION_DONE advances state after each animation completes - 9 unit tests covering all transitions and race condition scenario
|
@Tboy123-emm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict and fix workflow. |
Resolved conflict in package-lock.json by regenerating via npm install.
…kflow The 'build' script does not exist in package.json. expo export produces the 'dist' folder that checkBundleSize.js expects.
Contributor
Author
|
fixed workflow no conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #357