Share modal close #8651
Open
Share modal close #8651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ShareDashboardPopover had an onOutsideClick handler that conflicted with the toggle behavior. When clicking the Share button to close: 1. The click was detected as 'outside click' (outside popover content) 2. onOutsideClick set isOpen=false 3. Trigger's toggle action then set isOpen back to true 4. Result: popover stayed open Fixed by removing the redundant onOutsideClick handler since bits-ui's Popover component already handles closing on outside clicks by default. This makes the behavior consistent with other top menu buttons (AI, Home, Bookmark, Alerts). Fixes APP-684 Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
Author
|
I see this error message: "The file does not exist at "/Users/eokuma/rill/web-admin/node_modules/.vite/deps/chunk-FSABRBUG.js?v=8258d98a" which is in the optimize deps directory. The dependency might be incompatible with the dep optimizer. Try adding it to |
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 25. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the Share Dashboard popover would not close when clicking the Share button a second time.
The
onOutsideClickhandler was removed fromShareDashboardPopoveras it conflicted with thebits-uiPopover's built-in toggle functionality, causing the popover to remain open. This change aligns the Share button's behavior with other top menu buttons.Checklist:
Linear Issue: APP-684