Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 7 additions & 35 deletions .github/workflows/web-test-code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ on:
pull_request:
paths:
- ".github/workflows/web-test.yml"
- ".github/workflows/web-test-code-quality.yml"
- "scripts/web-test-code-quality.sh"
- "web-admin/**"
- "web-common/**"
- "web-local/**"
Expand Down Expand Up @@ -33,39 +35,9 @@ jobs:
with:
node-version-file: '.nvmrc'

- name: NPM Install
run: npm install
# https://typicode.github.io/husky/how-to.html#ci-server-and-docker
- name: Web code quality checks
run: bash ./scripts/web-test-code-quality.sh
env:
HUSKY: 0

- name: lint and type checks for web common
if: steps.filter.outputs.common == 'true'
run: |-
cd web-common
npx svelte-kit sync
cd ..
npx eslint web-common --quiet
npx svelte-check --workspace web-common --no-tsconfig --ignore "src/features/dashboards/time-series/MetricsTimeSeriesCharts.svelte,src/features/dashboards/time-series/MeasureChart.svelte,src/features/dashboards/time-controls/TimeControls.svelte,src/components/data-graphic/elements/GraphicContext.svelte,src/components/data-graphic/guides/Axis.svelte,src/components/data-graphic/guides/DynamicallyPlacedLabel.svelte,src/components/data-graphic/guides/Grid.svelte,src/components/data-graphic/compositions/timestamp-profile/TimestampDetail.svelte,src/components/data-graphic/marks/Area.svelte,src/components/data-graphic/marks/ChunkedLine.svelte,src/components/data-graphic/marks/HistogramPrimitive.svelte,src/components/data-graphic/marks/Line.svelte,src/components/data-graphic/marks/MultiMetricMouseoverLabel.svelte,src/features/column-profile/column-types/details/SummaryNumberPlot.svelte,src/stories/Tooltip.stories.svelte,src/lib/number-formatting/__stories__/NumberFormatting.stories.svelte"

- name: lint and type checks for web local
if: steps.filter.outputs.local == 'true'
run: |-
cd web-local
npx svelte-kit sync
cd ..
npx eslint web-local --quiet
npm run check -w web-local

- name: lint and type checks for web admin
if: steps.filter.outputs.admin == 'true'
run: |-
cd web-admin
npx svelte-kit sync
cd ..
npx eslint web-admin --quiet
npx svelte-check --workspace web-admin --no-tsconfig

- name: type check non-svelte files (with temporary whitelist)
run: |-
bash ./scripts/tsc-with-whitelist.sh
ADMIN: ${{ steps.filter.outputs.admin }}
LOCAL: ${{ steps.filter.outputs.local }}
COMMON: ${{ steps.filter.outputs.common }}
Loading
Loading