feat (AI): Feedback system #8614
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
reviewed
Jan 14, 2026
Collaborator
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Leaving comments for initial round of review.
| // Log the error but still return a response | ||
| s.logger.Warn("failed to analyze feedback", zap.String("session_id", s.id), zap.Error(err)) | ||
| return &UserFeedbackResult{ | ||
| Response: "Thanks for your feedback. I apologize that my response didn't meet your expectations. I'll use this to improve.", |
Collaborator
There was a problem hiding this comment.
nit: should we not add the error here?
| this.conversationQuery = createQuery(queryOptionsStore, queryClient); | ||
|
|
||
| // Hydrate feedback state when conversation data loads | ||
| this.conversationQuery.subscribe((query) => { |
Collaborator
There was a problem hiding this comment.
nit: need to handle unsub to avoid leaks
| private async startStreaming(request: { | ||
| prompt?: string; | ||
| context?: RuntimeServiceCompleteBody; | ||
| userFeedbackContext?: { |
Collaborator
There was a problem hiding this comment.
Why not use V1UserFeedbackContext?
| DeveloperAgentContext developer_agent_context = 12; | ||
| // Optional feedback context. If provided, the router_agent calls the user_feedback tool, | ||
| // which records feedback and, for negative feedback, attributes the cause. | ||
| UserFeedbackContext user_feedback_context = 13; |
Collaborator
There was a problem hiding this comment.
nit: missing param in CompleteRequest and its handling in chat.go
| return nil, fmt.Errorf("agent %q not found", args.Agent) | ||
| } | ||
| // User feedback | ||
| case args.UserFeedbackArgs != nil: |
Collaborator
There was a problem hiding this comment.
Whats wrong with using Agent arg instead? If there is a legitimate reason please add a comment somewhere.
| ...context, | ||
| prompt: request.prompt, | ||
| // Don't send agent for feedback - let router handle user_feedback directly | ||
| agent: request.userFeedbackContext ? undefined : this.agent, |
Collaborator
There was a problem hiding this comment.
Same here, agent is for routing directly. So we could just send ToolName.FeedbackAgent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds thumbs-up/thumbs-down buttons to the AI chat. Users can submit positive or negative feedback. Negative feedback is analyzed by the LLM to attribute the issue to one of:
rill: the AI made an error or misunderstood the questionproject: the project is missing data or has incomplete documentationuser: the question was ambiguous or outside the AI's scopeFor project and user attributions, users receive a suggested action to help them get better results.
Implements this tech design. Closes APP-555.
Checklist: