Skip to content

fix: legacy iso time range comparisions in reports #8099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdityaHegde merged 1 commit into from
Oct 8, 2025
Merged

fix: legacy iso time range comparisions in reports #8099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web-common/src/features/alerts/alert-preview-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ function getAlertPreviewQueryRequest(
timeControlArgs,
exploreSpec,
);

req.limit = "50"; // arbitrary limit to make sure we do not pull too much of data
if (!timeControlArgs.selectedTimeRange?.end) return req;

Expand Down
26 changes: 17 additions & 9 deletions web-common/src/features/dashboards/time-controls/time-range-mappers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,28 +105,36 @@ export function mapSelectedComparisonTimeRangeToV1TimeRange(
return undefined;
}

let isoDuration = timeRange.isoDuration;
const name = selectedComparisonTimeRange.name;

if (
timeRange.expression &&
TIME_COMPARISON[selectedComparisonTimeRange.name]?.rillTimeOffset
) {
const rt = parseRillTime(timeRange.expression);
return {
expression:
rt.toString() +
" offset " +
TIME_COMPARISON[selectedComparisonTimeRange.name]?.rillTimeOffset,
};
if (!rt.isOldFormat) {
return {
expression:
rt.toString() +
" offset " +
TIME_COMPARISON[selectedComparisonTimeRange.name]?.rillTimeOffset,
};
} else {
// Handle old syntax differently until we have the backend parser updated.
isoDuration = timeRange.expression;
}
}

const comparisonTimeRange: V1TimeRange = {};
switch (selectedComparisonTimeRange.name) {
switch (name) {
default:
comparisonTimeRange.isoOffset = selectedComparisonTimeRange.name;
comparisonTimeRange.isoDuration = timeRange.isoDuration;
comparisonTimeRange.isoDuration = isoDuration;
break;
case TimeComparisonOption.CONTIGUOUS:
comparisonTimeRange.isoOffset = comparisonTimeRange.isoDuration =
timeRange.isoDuration;
isoDuration;
break;

case TimeComparisonOption.CUSTOM:
Expand Down