Sync code improvements from dev-to-unidisk branch#10
Merged
rigreco merged 3 commits intoNov 6, 2025
Conversation
Selective merge of code quality improvements from the historical dev-to-unidisk branch (5 years old), preserving modern workflows. Modified Files (7 assembly files): - AppleII/FP-ADD/Unidrive4.S - AppleII/Integer-adc-1-Byte/Unicalc.S - AppleII/Integer-adc-2-Byte/Unidrive2.S - AppleII/Integer-adc-2-Byte/UnidriveU.S - AppleII/Memory-dump/Uniprox.S - AppleII/Memory-dump/Uniproz.S - AppleII/N-integer-adc-2-Byte/Unidrive3.S New Files (6 files): - AppleII/FP-operations/Conv3p.S (BASIC-FP converter) - _FileInformation.txt files (3) - UNIFUN2.bas, UNIDFUN3.bas (2) Changes: Cosmetic only (headers, directives, indentation) No logic modifications - compilation identical Modern workflows preserved (Build.yml v5, Build-Project.yml) +356 insertions, -162 deletions, 13 files changed
ProDOS volume names cannot contain hyphens, underscores or spaces. Projects like 'FP-ADD' were causing build failures. Changes: - Sanitize project name by removing -, _, and spaces - Truncate to 15 characters (ProDOS max) - Apply to volume name and all file paths Transforms: - 'FP-ADD' → 'FPADD' - 'Integer-adc-1-Byte' → 'Integeradc1Byt' - 'Memory-dump' → 'Memorydump' Fixes build error: Error: Invalid Prodos name 'FP-ADD'
The command 'tr -d "-_"' was interpreting -_ as an option. Split into separate tr commands to avoid syntax issues. Before: tr -d '-_' After: tr -d '_' | tr -d '-' | tr -d ' ' This properly removes hyphens, underscores and spaces.
rigreco
deleted the
claude/sync-code-improvements-011CUsJifp8nxnU5xks2YLi3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selective merge of code quality improvements from the historical
dev-to-unidiskbranch (created ~5 years ago). This PR brings cosmetic improvements only while preserving all modern workflow infrastructure (Build.yml v5, Build-Project.yml, ubuntu-24.04).Files Changed (13 total)
Modified Assembly Files (7 files)
AppleII/FP-ADD/Unidrive4.SAppleII/Integer-adc-1-Byte/Unicalc.SAppleII/Integer-adc-2-Byte/Unidrive2.SAppleII/Integer-adc-2-Byte/UnidriveU.SAppleII/Memory-dump/Uniprox.SAppleII/Memory-dump/Uniproz.SAppleII/N-integer-adc-2-Byte/Unidrive3.SNew Files (6 files)
AppleII/FP-operations/Conv3p.S(143 lines) - BASIC ↔ FP format converterAppleII/FP-ADD/_FileInformation.txtAppleII/Integer-adc-1-Byte/_FileInformation.txtAppleII/Integer-adc-2-Byte/UNIFUN2.basAppleII/Memory-dump/_FileInformation.txtAppleII/N-integer-adc-2-Byte/UNIDFUN3.basChanges Made
All changes are cosmetic only - verified safe with no logic modifications:
1. Standardized File Headers
1. Explicit Merlin32 Directives